It should be stated that `ip-detect` script should not have comments

Description

Attached are the two ip-detect scripts. One of the script starts with

this script is then passed to `subprocess.check_output` which does not seem to behave well with comments.

Thing is that the file provided by the doc is completely fine but if someone is writing own script then they should be aware of this and hence it should be mentioned in the documentation.

I am also attaching the logs for what error we get when using a script with comment.
this log can is generated by following these steps

use the "ip-detect with comments" and create config
follow the cli installation

--deploy action will succeed
--postflight will eventually timeout as the quorum never comes up

in the master nodes we see that the exhibitor is failing due to the ip-detect script

Activity

Show:
Rohit Hazra
February 1, 2017, 9:42 PM
Joel Hamill
February 1, 2017, 6:25 PM

excellent! feel free to assign to me when it's ready.

Rohit Hazra
February 1, 2017, 6:11 PM

I am actually planning a PR today, if that seems fit.

Joel Hamill
February 1, 2017, 6:06 PM

can you check in to this? i'm thinking the doc should be updated with something like `The IP detect script must begin with `#!/bin/sh` as shown. Do not include any comments before this.`

Assignee

Joel Hamill

Components